- Sep 10, 2018
-
-
Benjamin Rokseth authored
-
Benjamin Rokseth authored
covered: C4::SIP::ILS::Transaction::Checkin->do_checkin C4::SIP::ILS::Transaction::Checkout->do_checkout C4::SIP::Sip::MsgType->handle_checkout (add branch) circ/circulation.pl circ/renew.pl circ/returns.pl
-
Benjamin Rokseth authored
This is the Community subclass of Circulation that should be run as default to handle the basic Circulation, and should be interchangable with today's functionality. It also adds SIP integration. to use, add the following in the config section of koha-conf.xml: <core_modules> <circulation>Core::Community::Circulation</circulation> <sip>Core::Community::Circulation::SIP</sip> </core_modules> This is also the default if not set.
-
Benjamin Rokseth authored
This is the Circulation subclass of Core. It is a work in progress, but ideally all neccessary subfunctions should be overridable, and it should consist of a bare minimum of functionality for handling circulation. It is a rewrite of C4::Circulation. To use, add this in the config section in koha-conf.xml and restart plack: <core_modules> <circulation>Core::Circulation</circulation> </core_modules>
-
Benjamin Rokseth authored
- Core::Exceptions - Core::Prefs This is the main class of Core, along with siblings Prefs - to handle sysprefs and overrides, as well as Exceptions - Also included are the Makefile and koha-conf setup
-
Benjamin Rokseth authored
ILS::Transaction was missing branch param for unknown reason, since all transactions needs a branch
-
- Aug 31, 2018
-
-
Nick Clemens authored
To test: 1 - Setup and run selenium server as outlined here: https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha 2 - sudo koha-shell kohadev 3 - prove -v t/db_dependent/selenium/administration_tasks.t 4 - All should be green Signed-off-by:
Tomas Cohen Arazi <tomascohen@theke.io> All good! Signed-off-by:
Nick Clemens <nick@bywatersolutions.com>
-
Tomás Cohen Arazi authored
Signed-off-by:
-
Tomás Cohen Arazi authored
This patch adds the /patrons/{patron_id}/account/credits endpoint, that can be used to add credits to a patron's account. It is implemented so the new credits are used to pay existing debts. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests pass! - Make your favourite REST testing tool (RESTer on Firefox?) do: POST /api/v1/patrons/{patron_id}/account/credits { "amount": 100 } - Play with other possible attributes on the credit object. - Sign off :-D Signed-off-by:Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by:
Josef Moravec <josef.moravec@gmail.com> Signed-off-by:
-
Tomás Cohen Arazi authored
Signed-off-by:
-
Tomás Cohen Arazi authored
This patch makes the apache configuration for the reverse proxy (required for Plack) so it sets the X-FORWARDED-PROTO header correctly for Plack::Middleware::ReverseProxy to use it. Signed-off-by:
Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> Signed-off-by:
Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Since we actually resolve 19799 now (Changing language on OPAC redirects back to homepage), I will move that code to a new enh report. Signed-off-by:
-
Nightly Build Bot authored
This is a result of Bug 21068: Remove NorwegianPatronDB related code Signed-off-by:
Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by:
-
Nick Clemens authored
Signed-off-by: -
Katrin Fischer authored
Signed-off-by: -
Nick Clemens authored
Signed-off-by:
Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by:
-
Nick Clemens authored
Signed-off-by:
-
Colin Campbell authored
Updates column name from rrp -> replacementprice when creating order from EDI QUOTE message Also ensure other rrp_tax* fields populated Signed-off-by:
-
Nick Clemens authored
Signed-off-by:
-
Nick Clemens authored
To test: 0 - Apply patches and updatedatabase 1 - Add an order to a basket 2 - You should note new 'Retail price field' 3 - You should have a separate 'Replacement price' field 4 - Enter values and ensure they are saved as expected 5 - In the basket you should see the replacement price 6 - Modify order and ensure value is loaded and saved correctly 7 - Add and cancle an order and esure replacement price shows/saves 8 - Close basket 9 - Receive an order 10 - You should be able to edit replacement price 11 - 'retail price' field is not editable 12 - Check associated item, replacement price in item should be updated 13 - Cancel receipt, check item. receive again with new replacement price, check item 14 - Price should be correctly updated 15 - Finish receipt, value should show in table 16 - Test with receive from file Signed-off-by:
-
Nick Clemens authored
Signed-off-by:
-
Tomás Cohen Arazi authored
Signed-off-by:
-
Tomás Cohen Arazi authored
Signed-off-by:
-
Tomás Cohen Arazi authored
Signed-off-by:
-
Jonathan Druart authored
Signed-off-by:
-
Jonathan Druart authored
Remove: - BIB_INDEX_MODE and AUTH_INDEX_MODE env var - bib_index_mode and auth_index_mode options from scripts - Warnings from about page, just kept one if zebra_bib_index_mode or zebra_auth_index_mode still exist in config and are set to grs1 Test plan: - Install Koha from src - Install Koha from pkg - Read the code, carefully! Signed-off-by:
-
Jonathan Druart authored
Signed-off-by:
-
Owen Leonard authored
This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Acquisitions home page -> Click a "spent" value for a fund. - Acquisitions -> Vendor -> Vendor details. - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Vendor -> Receive shipments - Click an "Invoice number" link in the table of shipments. - Click "Receive" for one of the titles in pending orders. Signed-off-by:Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by:
-
Owen Leonard authored
This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Acquisitions -> Vendor -> Add to basket -> From an existing record -> Search results. - Order - Acquisitions -> Vendor -> Add to basket -> From a subscription - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Acquisitions -> Vendor -> Add to basket -> From an external source - Search for an title which already exists in your catalog - Select a search result which has an ISBN matching the title in your catalog. - Order. The duplicate warning page is the one modified. - Acquisitions home page -> Click an "Ordered" value for a fund. Signed-off-by: -
Jonathan Druart authored
Signed-off-by:
-
Jonathan Druart authored
Those calls to C4::Items::GetItemnumbersForBiblio can be replaced with my @itemnumbers = Koha::Items->search({ biblionumber => $biblionumber})->get_column("itemnumber") Test plan: - Use the GetAvailability service of ILS-DI - Try to place a hold on an item that is available and another one - Use the batch record deletion tool to remove record with and without items. Signed-off-by: -
Josef Moravec authored
Test plan: 1) Set up your SIP: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2) Run: misc/sip_cli_emulator.pl -a localhost -p 6001 -su <login> -sp <passsword> -l <library_code> --patron <borrowernumber> -s "Y " -m patron_information the -s parameter says what kind of additional information you want to see 3) Check the response: if the requested patron has waiting hold, there is field "AS" with the barcode of waiting item The right response looks like this: 64 00120180817 052434000100000000000000000000AOCPL|AA1|AEKoha Admin|BLY|CC5|AS39999000004410|PCS|PIY|AFGreetings from Koha. | More reading ;) http://multimedia.3m.com/mws/media/355361O/sip2-protocol.pdf Signed-off-by:
-
Jonathan Druart authored
Test plan: git grep GetBarcodeFromItemnumber should not return anything Signed-off-by:
-
Jonathan Druart authored
Those calls to C4::Items::GetBarcodeFromItemnumber can be replaced with my $barcode = Koha::Items->find($itemnumber)->barcode; But if we are not sure that the item exists, we should test the return of ->find before ->barcode Test plan: - Edit an item - Check an item in - Test SIP - I do not really know how to trigger that code, apparently misc/sip_cli_emulator.pl does not deal with holds. Any ideas? Signed-off-by:
-
- Aug 30, 2018
-
-
Jonathan Druart authored
http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for the last 3 patrons who checked out the items. I have no idea if it is a desired effects but, as this code has been there for a very long time (2005), I suspect it's not. The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say anything about the checkouts info. Test plan: hit /ilsdi.pl?service=GetRecords&id=1 and confirm the info about items are displayed correctly Signed-off-by:
-
Nick Clemens authored
Signed-off-by: -
Katrin Fischer authored
Signed-off-by: -
Kyle M Hall authored
Some libraries don't wish to require librarians to confirm each hold during checkin. Instead they would like to only be alerted that a hold was filled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref HoldsAutoFill 4) Check in an item that should be trapped for a hold 5) Note that instead of the modal asking if the hold should be filled, instead you get a message box showing the hold was filled, along with a button to print the hold slip. 6) Enable the new syspref HoldsAutoFillPrintSlip 7) Repeat step 4 8) Note the same behavior, but this time the print dialog displays automatically Signed-off-by:
Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by:
-
Nick Clemens authored
Signed-off-by: -
Nick Clemens authored
Signed-off-by: -
Josef Moravec authored
Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by:
-
