deichman merge requestshttp://gitlab.deichman.no/digibib/deichman/-/merge_requests2022-10-17T11:25:25Zhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/678DEICH-6402 - Simplifications2022-10-17T11:25:25ZTom AdamDEICH-6402 - SimplificationsAnette has reported a problem, the mini campaign was displaying placement selector, which is basically a mistake. This commit simplifier campaign type change. The default valur set logic is moved to the `updateProperties(screenPresentati...Anette has reported a problem, the mini campaign was displaying placement selector, which is basically a mistake. This commit simplifier campaign type change. The default valur set logic is moved to the `updateProperties(screenPresentationType, campaignType)` function, which makes getting rid of a bunch of additional complexity possible.
Closes DEICH-6402Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/676DEICH-0000 - Validation framework documentation + some cleanup.2022-10-17T14:29:38ZTom AdamDEICH-0000 - Validation framework documentation + some cleanup.Jeg har lagt til dokumentasjon om valideringsrammeverket. Gjerne kom med innspill, hvis beskrivelsen er fornuftig eller mangler noe.
Closes DEICH-0000Jeg har lagt til dokumentasjon om valideringsrammeverket. Gjerne kom med innspill, hvis beskrivelsen er fornuftig eller mangler noe.
Closes DEICH-0000Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/679DEICH-6405 - Added minmax to have definite minimum width in grid layout2022-10-18T06:21:58ZTom AdamDEICH-6405 - Added minmax to have definite minimum width in grid layoutThis fixes the brødtekst width issue.
Closes DEICH-6405This fixes the brødtekst width issue.
Closes DEICH-6405Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/680DEICH-6404 - Added mailto: as allowed protocol prefix.2022-10-18T06:25:31ZTom AdamDEICH-6404 - Added mailto: as allowed protocol prefix.Closes DEICH-6404Closes DEICH-6404Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/681DEICH-6403 - Invalid section improvements2022-10-18T10:54:04ZTom AdamDEICH-6403 - Invalid section improvementsIf a section/block section is not valid, it gets opened by default, and no sections/block sections with invalid data can be closed. This required changes in ValidationContext (to fire event about sub-context validity) and in DragAndDropI...If a section/block section is not valid, it gets opened by default, and no sections/block sections with invalid data can be closed. This required changes in ValidationContext (to fire event about sub-context validity) and in DragAndDropItem, to propagate content validity state. Also sections/block sections had to wire up and propaget their validity state to their parent DragAndDropItem instance.
Also dumping allValid flag as part og $$_dumpValidationContext().
Fixed issue with sometimes unset validationContext data in $$_dumpValidationContext().
Some layout goodies (using Grid/GridItem in EditPageSectionGeneric)
Closes DEICH-6403Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/674DEICH-6392 - Using endTime for library event interval filtering.2022-10-26T09:57:50ZTom AdamDEICH-6392 - Using endTime for library event interval filtering.Closes DEICH-6392Closes DEICH-6392Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/650DEICH-6220 registration: better feedback2022-10-27T08:11:20ZPetter Goksøyr ÅsenDEICH-6220 registration: better feedbackGive proper feedback when registering users with missing
address or with address not in Norway.
This commit only addresses registration by staff, not
self-registration.
Closes DEICH-6220Give proper feedback when registering users with missing
address or with address not in Norway.
This commit only addresses registration by staff, not
self-registration.
Closes DEICH-6220http://gitlab.deichman.no/digibib/deichman/-/merge_requests/682DEICH-6408 - Fixed JS hangup on error from server while saving2022-10-27T12:15:53ZTom AdamDEICH-6408 - Fixed JS hangup on error from server while savingAlso added more user-friendly alert message to the user.
General handling of HTTP status errors (401/403/500 so far).
Removed deepClone, and added a more capable seepCopy to lib/util.js.
Removed fetch polyfill try-catch in util.js. Polyf...Also added more user-friendly alert message to the user.
General handling of HTTP status errors (401/403/500 so far).
Removed deepClone, and added a more capable seepCopy to lib/util.js.
Removed fetch polyfill try-catch in util.js. Polyfill is not used any longer.
Closes DEICH-6408Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/683DEICH-6409 - Fixed + some more cleanup2022-10-27T13:04:09ZTom AdamDEICH-6409 - Fixed + some more cleanupUsing common sort button component.
Using grid item instead of table to display ReportingList/ReportingListRow.
Somewhat polished SortOrderButton.
Closes DEICH-6409Using common sort button component.
Using grid item instead of table to display ReportingList/ReportingListRow.
Somewhat polished SortOrderButton.
Closes DEICH-6409Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/684DEICH-6411 - Sibyl - Fixed debug config and coding error related to events/fr...2022-10-28T07:55:04ZTom AdamDEICH-6411 - Sibyl - Fixed debug config and coding error related to events/from(Start/End)Time/to(Start/End)Time sortDEICH-6411 - Fixed debug config and coding error
fromStartTime and toStartTime was overwritten by the string representation of fromEndTime and toEndTime.
go 1.19 upgrade done.
Fixed debug Dockerfile.
...DEICH-6411 - Fixed debug config and coding error
fromStartTime and toStartTime was overwritten by the string representation of fromEndTime and toEndTime.
go 1.19 upgrade done.
Fixed debug Dockerfile.
Added path to assets as env variable.
DEICH-6411 - TK - using start time for date sorting
This way events on the same day show up in correct order. Otherwise, the order within a day is random.
Finalizes DEICH-0000 - Upgraded to go 1.19Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/685DEICH-6415 - TK small fixes2022-11-04T09:09:25ZTom AdamDEICH-6415 - TK small fixesVenter på avklaringer ifm interval velger fra Maria Bagtas. Derfor er requesten i Draft.
DEICH-6415 - Planyo Id dirty fix
DEICH-6415 - Interval end is inclusive
The following components are going to change behaviour thanks to the ...Venter på avklaringer ifm interval velger fra Maria Bagtas. Derfor er requesten i Draft.
DEICH-6415 - Planyo Id dirty fix
DEICH-6415 - Interval end is inclusive
The following components are going to change behaviour thanks to the change:
-PageEdit (aktualitessider)
-EditCampaignContent (kampanjer)
-EditCampaignPublication (kampanjer)
-EditDeviatingOpeningHours (avvikende åpningstider)
The last day of the selected interval is also included in the selected date range.
Closes DEICH-6415Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/686DEICH-6306 special handling of bjørvika opening hours2022-11-08T09:40:15ZPetter Goksøyr ÅsenDEICH-6306 special handling of bjørvika opening hoursIn Tjenestekatalogen bjørvika is to be administered as a "meråpent" library. However
this is just to have a way to communicate that the building is not fully manned
in the full opening hours. Thus, we add specific labels for Bjørvika ope...In Tjenestekatalogen bjørvika is to be administered as a "meråpent" library. However
this is just to have a way to communicate that the building is not fully manned
in the full opening hours. Thus, we add specific labels for Bjørvika opening
hours to reflect this.
Closes DEICH-6306http://gitlab.deichman.no/digibib/deichman/-/merge_requests/687DEICH-6412 image-api: remove usage of static.deichman.no fallback2022-11-15T13:07:45ZBenjaminDEICH-6412 image-api: remove usage of static.deichman.no fallbackCloses DEICH-6412Closes DEICH-6412http://gitlab.deichman.no/digibib/deichman/-/merge_requests/688DEICH-6426 use correct timestamp format for search query param2022-11-22T08:48:53ZPetter Goksøyr ÅsenDEICH-6426 use correct timestamp format for search query paramCUTOFF_TO_DATE is being used as part of elastic query, and not euler.
Closes DEICH-6426CUTOFF_TO_DATE is being used as part of elastic query, and not euler.
Closes DEICH-6426http://gitlab.deichman.no/digibib/deichman/-/merge_requests/689DEICH-6429 - Avvikende/Meråpent opprydning2022-11-25T09:41:54ZTom AdamDEICH-6429 - Avvikende/Meråpent opprydningDEICH-6429 - Fixed arrogant date monster
It was just creeping through the deviating hours like hell. Until today. Now this bastard was caught, and eliminated.
Reason for the bug was that EditInterval did not allow for s...DEICH-6429 - Fixed arrogant date monster
It was just creeping through the deviating hours like hell. Until today. Now this bastard was caught, and eliminated.
Reason for the bug was that EditInterval did not allow for setting the periodStart/periodEnd besides the initial setup. Now there was made a change to set the interval ends in flatpickr as these props are set, and fire the interval change in the flatpickr options hook. It was actually he opposite before, thus causing problems.
DEICH-6429 - Added cleanup logic for meråpent
Now the deviating hours are set correctly.
- normal opening open flag is set to true;
- openFrom/To is set to mannedFrom/To
- manned, mannedFrom/To is deleted.
Closes DEICH-6429.Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/690DEICH-6353 - 6XY$x$y$z mapping fix + test code improvements2022-12-08T09:35:42ZTom AdamDEICH-6353 - 6XY$x$y$z mapping fix + test code improvementsDEICH-6353 - 6XY$x$y$z mapping fix + test code improvements
Mapping changes:
-600
Missing mapping for $y was added
-610
Had no $x/$y/$z mapping at all, was fixed.
-611
Had no $x/$y/$z mapping, fixed.
-630...DEICH-6353 - 6XY$x$y$z mapping fix + test code improvements
Mapping changes:
-600
Missing mapping for $y was added
-610
Had no $x/$y/$z mapping at all, was fixed.
-611
Had no $x/$y/$z mapping, fixed.
-630
Had no $x/$y/$z mapping, fixed.
-651
There was an inhereted codeing error, $x is used for reieshåndbok mapping, but if the value is not “reisehåndbøker” $x was mapped to PLACE. Fixed, $x is mapped til SUBJECT now. Added support for multiple occurrences of $x (as defined in LOC MARC21 specification).
$a and $z both maps to PLACE (was already done so before) - not changed.
$y mapping was missing, fixed.
-653
Has no $x/$y/$z.
-655
Here there is an exception, $z is mapped to Work/NATIONALITY (and this is correct this way). Otherwise added missing $x/$y mapping.
Added required tests to cover all these new cases.
Removed disabled test case test6XXxSubjects - those scenarios were covered now.
Test utility improvements:
-Renamed assertDeichModelContainsTriple to assertDeichModelContainsExactlyOneTriple, name was misleading.
Added public static void assertDeichModelContainsSubjectPrefLabels(Model deichModel, Ontology forOntology, String ...prefLabels) replacing assertDeichModelContainsSubjectsWithPrefLabels, assertDeichModelContainsSubjectWithPrefLabel, assertDeichModelContainsSubjectPlaceWithPrefLabel
DEICH-6353 - Removed unused mapping and invalid test cases.
DEICH-6353 Mapping changes 082-083 - classification
Closes DEICH-6353Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/691DEICH-6436 tjenestekat: add some simplified tour and group visit concepts for...2023-01-02T08:33:59ZBenjaminDEICH-6436 tjenestekat: add some simplified tour and group visit concepts for reportingsparql i jira: https://jira.oslo.kommune.no/browse/DEICH-6436sparql i jira: https://jira.oslo.kommune.no/browse/DEICH-6436http://gitlab.deichman.no/digibib/deichman/-/merge_requests/662Draft: DEICH-6379 - Library event - service filtering bug2022-10-27T11:43:09ZTom AdamDraft: DEICH-6379 - Library event - service filtering bugTo be fixed as a general cleanup for filtering in TK.
DEICH-6379 - TK part
Code cleanup and simplified hit handling - no need to filter since Sibyl is smart enough to provide us with correctly filtered dataset. 😍😍
The filter p...To be fixed as a general cleanup for filtering in TK.
DEICH-6379 - TK part
Code cleanup and simplified hit handling - no need to filter since Sibyl is smart enough to provide us with correctly filtered dataset. 😍😍
The filter parameters are sent in the query string if limitToLibraryEventServices is set to true.
DEICH-6379 - Sibyl part
Added option to exclude value in search fields for services. In that case the value must be defined using the not.fielf.XYZ convention.
This was needed to get correct result and aggregation for the service filter when creating a library event.
Also updated indexing - added fields status.id and serviceType.id.
Closes DEICH-6379Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/594Draft: DEICH-5792 show production year for films in grid-mode2022-05-27T09:09:28ZTom AdamDraft: DEICH-5792 show production year for films in grid-modeDet er en del ting rundt saken som må avklares - derfor er dette i DRAFT.
Show in place of languages.
Closes DEICH-5792Det er en del ting rundt saken som må avklares - derfor er dette i DRAFT.
Show in place of languages.
Closes DEICH-5792http://gitlab.deichman.no/digibib/deichman/-/merge_requests/581DEICH-6251 replace workseries suggestion node in wizard2022-05-09T23:23:43ZPetter Goksøyr ÅsenDEICH-6251 replace workseries suggestion node in wizardCloses DEICH-6251Closes DEICH-6251