deichman merge requestshttp://gitlab.deichman.no/digibib/deichman/-/merge_requests2022-08-16T07:58:35Zhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/630DEICH-6330 - result list focus on tab2022-08-16T07:58:35ZTom AdamDEICH-6330 - result list focus on tabFixed tab index.
Closes DEICH-6330Fixed tab index.
Closes DEICH-6330Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/629DEICH-6264 - Euler - upgrade to Java 172022-08-24T09:19:54ZTom AdamDEICH-6264 - Euler - upgrade to Java 17Quite a lot of dependencies had to be upgraded. Java 11 is from 2018, and a lot has happened in 4 years.
-Upgraded Spring boot, and numerous third party libraries required by upgrade to Java 17.
-Added @EqualsAndHashCode(callSuper=true)...Quite a lot of dependencies had to be upgraded. Java 11 is from 2018, and a lot has happened in 4 years.
-Upgraded Spring boot, and numerous third party libraries required by upgrade to Java 17.
-Added @EqualsAndHashCode(callSuper=true) to no.deichman.euler.api.resource.jsonapi.vos.* classes.
-Minor code improvements allowed by Java 17 and the Java language (like method ref, which was supported by Java 11 as well).
-Replaced springfox with springdoc-openapi, since springfox does not support latest versions of Spring boot, and the project is dead in the last 2 years.
Closes DEICH-6264Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/628DEICH-6326 - Moved click handler to higher level parent+pointer fixes.2022-08-24T18:32:04ZTom AdamDEICH-6326 - Moved click handler to higher level parent+pointer fixes.Moved click handler to higher level parent+pointer fixes.
+bit of code cleanup. 🧹
Closes DEICH-6326Moved click handler to higher level parent+pointer fixes.
+bit of code cleanup. 🧹
Closes DEICH-6326Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/627DEICH-6325 - Upgrade to WebPack 5 + cache busting 🚀2022-08-12T12:26:10ZTom AdamDEICH-6325 - Upgrade to WebPack 5 + cache busting 🚀- Upgraded to webpack 5 🎉
- Fixed module reload for WebPack 5, however could only make it work with sockjs.
- Added automatic cleanup for `public` folder - otherwise it gets full with different bundle cache busted bundle
versions...- Upgraded to webpack 5 🎉
- Fixed module reload for WebPack 5, however could only make it work with sockjs.
- Added automatic cleanup for `public` folder - otherwise it gets full with different bundle cache busted bundle
versions.
- Added cache busting 🎉
- The webpack config was modified to add `contenthash` to the generated bundle names (both js, and css).
HtmlWebpackPlugin is used to generate public/index.html based on template stored in `./assets/index.html`.
- `global.css` was moved inside the `src/css` folder, and now included in `App.svelte`. All declarations were converted
to have global scope. This was required to avoid caching `global.css`, thus invalidating cache busting partially.
Closes DEICH-6325Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/626DEICH-6324 - Scroll fix2022-08-09T13:08:29ZTom AdamDEICH-6324 - Scroll fixFurther improvements require bigger changes in component layouts. This fix cures the problem described in the task, and also improves somewhat on tab header scroll behaviour for external details.
+code cleanup.
Closes DEICH-6324Further improvements require bigger changes in component layouts. This fix cures the problem described in the task, and also improves somewhat on tab header scroll behaviour for external details.
+code cleanup.
Closes DEICH-6324Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/625Koha: refactor availability queries for better DB locks handling2022-08-10T11:37:51ZBenjaminKoha: refactor availability queries for better DB locks handling```
o [DEICH-6323] {origin/DEICH-6323} DEICH-6323 koha: update ILL availability query
o DEICH-6323 koha: update deactivated availability count query
o DEICH-6323 koha: fix biblio availability query ref DEICH-5924
o DEICH-6323 koha: refac...```
o [DEICH-6323] {origin/DEICH-6323} DEICH-6323 koha: update ILL availability query
o DEICH-6323 koha: update deactivated availability count query
o DEICH-6323 koha: fix biblio availability query ref DEICH-5924
o DEICH-6323 koha: refactor availability queries to use less cpu and db locks
```http://gitlab.deichman.no/digibib/deichman/-/merge_requests/624DEIH-6321 improve availability information2022-08-08T07:44:15ZPetter Goksøyr ÅsenDEIH-6321 improve availability information* Show availability for items which are not reservable
* Hide "X på venteliste" for non-reservable items
* Move some logic from frontend to koha backend (reservable by format)
* Fix warning/bug with missing import
Closes DEICH-6321* Show availability for items which are not reservable
* Hide "X på venteliste" for non-reservable items
* Move some logic from frontend to koha backend (reservable by format)
* Fix warning/bug with missing import
Closes DEICH-6321http://gitlab.deichman.no/digibib/deichman/-/merge_requests/623DEICH-6322 cronicle: update version for vulnability patches and timezone fix2022-08-08T15:16:18ZBenjaminDEICH-6322 cronicle: update version for vulnability patches and timezone fixCloses DEICH-6322Closes DEICH-6322http://gitlab.deichman.no/digibib/deichman/-/merge_requests/622DEICH-6318 - Replaced DataList with Autocomplete in Fuge2022-08-12T12:23:27ZTom AdamDEICH-6318 - Replaced DataList with Autocomplete in FugeDEICH-6318 - DataList removal - AuthorizedValueSearch.svelte
DEICH-6318 - DataList removal - MediaTypeInput.svelte
DEICH-6318 - DataList removal - ExternalIdSelectInput.svelte
DEICH-6318 - DataList removal - LocationSignatureInput.sve...DEICH-6318 - DataList removal - AuthorizedValueSearch.svelte
DEICH-6318 - DataList removal - MediaTypeInput.svelte
DEICH-6318 - DataList removal - ExternalIdSelectInput.svelte
DEICH-6318 - DataList removal - LocationSignatureInput.svelte
A bit of extra job was done here, since AuthorizedValueLookupInput was modified to handle locationFormat, which is locally defined in location-format-suggestions.js. A prop called authorizedValuesSortedNorwegian was added to AuthorizedValueLookupInput, which takes precedence over server side fetch if present.
The values in location-format-suggestions.js were mapped to match the required object shape.
This solution makes uniform look and feel for locationFormat handling, and saves on number of code lines+complexity.
Property sourceAuthorityType is not needed any longer, and it was removed. It was used to distinguish between data lists, but this is not needed any longer since AutoComplete is used. That component takes care of unique ID generation on its own.
DEICH-6318 - Configured modern JS features (?. ??).
Note that fe-common is not the correct version yet, will be fixed after FE-common release.
DEICH-6318 - In case of `closeOnSelect === true` and `minCharsToSuggest === 0` the suggestion list did not close
DEICH-6318 - Layout improvements when not showing # of hits
* `Added` Autocomplete - `placeholder` property to set placeholder text for the input.
* `Added` Autocomplete - `labelFunction` property - to be used to extract label from whatever object.
* `Added` Autocomplete - no hits (ingen treff) is not displayed if no items are supplied or all of them were removed.
* `Added` Autocomplete - suggestion list is not displayed if no items are supplied or all of them were removed.
* `Added` Autocomplete - open/close icon is not displayed if no items are supplied or all of them were removed.
* `Added` Autocomplete - text input is disabled if no items are supplied or all of them were removed.
* `Added` Autocomplete - increased test coverage for user interaction tests (Autocomplete.test.ts).
* `Added` Autocomplete - added support for inputProps (props propagated to the input field).
* `Fixed` Autocomplete - better encapsulation in InternalItems - using private methods.
* `Fixed` Autocomplete - streamlined dropdown open event handling - using mouseDown all over the place to secure more
robust and concise functionality.
* `Fixed` Autocomplete - more consistent functionality if minCharsToSuggest is set to 0. The dropdown list can be closed
on all usual ways ([ESC], close icon, tabbing away/losing focus by any other means). Previously losing focus/close icon
was not working.
Closes DEICH-6318Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/621DEICH-6320 filter out deleted works when listing workseries2022-08-05T05:18:46ZPetter Goksøyr ÅsenDEICH-6320 filter out deleted works when listing workseriesCloses DEICH-6320Closes DEICH-6320http://gitlab.deichman.no/digibib/deichman/-/merge_requests/620DEICH-6315 use POST http method on login form2022-08-05T05:18:24ZPetter Goksøyr ÅsenDEICH-6315 use POST http method on login formThis avoids exposing credentials in URL for users with
javasrcipt disabled in the browser.
Closes DEICH-6315This avoids exposing credentials in URL for users with
javasrcipt disabled in the browser.
Closes DEICH-6315http://gitlab.deichman.no/digibib/deichman/-/merge_requests/619DEICH-6319 fix indexing of work/publication with corporation mainentry2022-08-03T11:29:27ZPetter Goksøyr ÅsenDEICH-6319 fix indexing of work/publication with corporation mainentryCloses DEICH-6319Closes DEICH-6319http://gitlab.deichman.no/digibib/deichman/-/merge_requests/618DEICH-6317 - Åpning med dblklikk fungerer ikke2022-08-02T18:35:50ZTom AdamDEICH-6317 - Åpning med dblklikk fungerer ikkeFixed+added support for tabIndex
Closes DEICH-6317Fixed+added support for tabIndex
Closes DEICH-6317Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/617DEICH-6134 - Using Autocomplete from frontend-common + FE-common - Bugfixes a...2022-08-01T07:53:15ZTom AdamDEICH-6134 - Using Autocomplete from frontend-common + FE-common - Bugfixes and build system improvements.**Note, that package-lock.json is not yet valid. FE-common changes must be code-reviewed released first, and npm -i must be run and then the file can be checked in with its up-do-date content.**
FE-common:
* `Added` CHANGELOG.md :)
* `...**Note, that package-lock.json is not yet valid. FE-common changes must be code-reviewed released first, and npm -i must be run and then the file can be checked in with its up-do-date content.**
FE-common:
* `Added` CHANGELOG.md :)
* `Added` `wide` option to AutoComplete
* `Added` CHANGELOG.md :)
* `Added` `npm run test:watch` to run the tests in watch mode
* `Added` Svelte diagnostics - sanity check for svelte files as part of the build process.
* `Added` New property - `wide` -, which makes Autocomplete take up all available horizontal space
* `Fixed` Rollup config is correct now, excludes svelte, and makes building with the latest svelte possible.
* `Fixed` Positioning of DropDown list - parent position had to be set top relative + styling improvements.
* `Fixed` Removed unneeded JSDoc types+Svelte Diagnostics issues fixed.
* `Fixed` Sourcemap support.
TK:
Closes DEICH-6314Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/616DEICH-6313 fuge: store bibsys-ID on new authorities2022-07-28T05:35:43ZPetter Goksøyr ÅsenDEICH-6313 fuge: store bibsys-ID on new authoritiesCloses DEICH-6313Closes DEICH-6313http://gitlab.deichman.no/digibib/deichman/-/merge_requests/615DEICH-6310 Front-end-common hosting common svelte components+TypeScript2022-07-26T12:21:02ZTom AdamDEICH-6310 Front-end-common hosting common svelte components+TypeScript-Removed old, unused stuff
-Configured project build system to potentially host multiple svelte components
-Separated classes and typed out from main svelte component
-Configured typescript+svelte /ts files and svelte script tags with pr...-Removed old, unused stuff
-Configured project build system to potentially host multiple svelte components
-Separated classes and typed out from main svelte component
-Configured typescript+svelte /ts files and svelte script tags with property lang set to "ts" are treated as TS/
-Configured eslint with TS plugin
-Added required types
-Added testing-library +jsDom - however, JSDom has such shortcomings that make it almost useless to test the Autocomplete component.
Closes DEICH-6310Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/614DEICH-6294 tk: allow creating events on previous dates2022-07-28T05:34:39ZPetter Goksøyr ÅsenDEICH-6294 tk: allow creating events on previous datesCloses DEICH-6294Closes DEICH-6294http://gitlab.deichman.no/digibib/deichman/-/merge_requests/613DEICH-6312: Deichman::Item::GetBiblioReserves: exclude item-level holds2022-07-21T08:41:23ZPetter Goksøyr ÅsenDEICH-6312: Deichman::Item::GetBiblioReserves: exclude item-level holdsCloses DEICH-6312Closes DEICH-6312http://gitlab.deichman.no/digibib/deichman/-/merge_requests/612DEICH-6311 koha: fix Deichman::Item::AvailableItemsCount2022-07-19T13:18:12ZPetter Goksøyr ÅsenDEICH-6311 koha: fix Deichman::Item::AvailableItemsCountAs it was, it always returned the number 1 (= number of rows), but
what we want is the actual count from the SQL query.
Closes DEICH-6311As it was, it always returned the number 1 (= number of rows), but
what we want is the actual count from the SQL query.
Closes DEICH-6311http://gitlab.deichman.no/digibib/deichman/-/merge_requests/611DEICH-6164 - datalist replaced by AutoComplete2022-07-18T10:46:02ZTom AdamDEICH-6164 - datalist replaced by AutoCompleteNew autocomplete component and build system improvements.
Closes DEICH-6164New autocomplete component and build system improvements.
Closes DEICH-6164Tom AdamTom Adam