deichman merge requestshttp://gitlab.deichman.no/digibib/deichman/-/merge_requests2022-07-18T10:46:02Zhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/611DEICH-6164 - datalist replaced by AutoComplete2022-07-18T10:46:02ZTom AdamDEICH-6164 - datalist replaced by AutoCompleteNew autocomplete component and build system improvements.
Closes DEICH-6164New autocomplete component and build system improvements.
Closes DEICH-6164Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/610DEICH-6304 change mapping of subjects with 600$t2022-08-03T11:29:55ZPetter Goksøyr ÅsenDEICH-6304 change mapping of subjects with 600$tPreviously this was mapped to a contribution on work, but now
it is mapped to a person as subject of work, plus work with
mainentry person as subject of work.
In addition, this commit also fixes automatic mapping of existing
persons as ...Previously this was mapped to a contribution on work, but now
it is mapped to a person as subject of work, plus work with
mainentry person as subject of work.
In addition, this commit also fixes automatic mapping of existing
persons as subject using bibsysId during catalouging in Fuge.
Closes DEICH-6304http://gitlab.deichman.no/digibib/deichman/-/merge_requests/609add koha UI component to add/update location labels and sorting2022-07-07T07:52:09ZBenjaminadd koha UI component to add/update location labels and sortingcadf4324d DEICH-6308 koha: update LocationLabels web component to a usable state
4f6f18268 DEICH-6308 koha: remove unused SetLocationLabel method and api call.
ff65f8475 DEICH-6308 koha: update location meta API to use sorting column
65b...cadf4324d DEICH-6308 koha: update LocationLabels web component to a usable state
4f6f18268 DEICH-6308 koha: remove unused SetLocationLabel method and api call.
ff65f8475 DEICH-6308 koha: update location meta API to use sorting column
65b8bb0f6 DEICH-6308 koha: add tool component for location labels and sorting updatehttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/608DEICH-6293 Swap frontpage blog link with podcast link2022-07-07T06:30:08ZPetter Goksøyr ÅsenDEICH-6293 Swap frontpage blog link with podcast linkCloses DEICH-6293Closes DEICH-6293http://gitlab.deichman.no/digibib/deichman/-/merge_requests/607DEICH-6291 Change hardcoded 'meråpent' opening hours, from 23 to 222022-06-27T05:03:09ZPetter Goksøyr ÅsenDEICH-6291 Change hardcoded 'meråpent' opening hours, from 23 to 22Closes DEICH-6291Closes DEICH-6291http://gitlab.deichman.no/digibib/deichman/-/merge_requests/606DEICH-6297 - Fixed.2022-06-29T07:59:18ZTom AdamDEICH-6297 - Fixed.Closes DEICH-6297Closes DEICH-6297Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/605DEICH-6296 - Added module level id generator.2022-06-29T09:02:18ZTom AdamDEICH-6296 - Added module level id generator.This way there is no id collision for input-datalist pairs.
Also removed export from `value` property. Should not be exposed.
Closes DEICH-6296This way there is no id collision for input-datalist pairs.
Also removed export from `value` property. Should not be exposed.
Closes DEICH-6296Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/604DEICH-6281 - Fixed validation so that it is instantly fired as the valid flag...2022-06-24T10:09:49ZTom AdamDEICH-6281 - Fixed validation so that it is instantly fired as the valid flag...DEICH-6281 - Fixed validation so that it is instantly fired as the valid flag is updated using svelte reactive declarations.
Note, that EditNumber is used only one place with required set to false, so testing that component in validatio...DEICH-6281 - Fixed validation so that it is instantly fired as the valid flag is updated using svelte reactive declarations.
Note, that EditNumber is used only one place with required set to false, so testing that component in validation sense is not possible by testers. Did a local testing, works ok.
EditNumber`s functionality was improved. The previous version allowed typing of non-numeric characters in the input fields, and there was no error reported at all. In this case the value was set to undefined, but still looked strange, that the create/save button was enabled. This new version fixes this issue. The implementation was somewhat cumbersome since I had to listen to onkeyup event, and check the input validity through input.validity.valid.
Closes DEICH-6281Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/603DEICH-6288 - Tekniske forbedringer - EditDropdown2022-06-23T13:12:34ZTom AdamDEICH-6288 - Tekniske forbedringer - EditDropdownAlso made the control somewhat smarter: if no item is selected, and enableEmptySelection is false, the --- Velg --- placeholder is displayed. It makes setting up of new entities much more user-friendly. Previously a valid selection, and ...Also made the control somewhat smarter: if no item is selected, and enableEmptySelection is false, the --- Velg --- placeholder is displayed. It makes setting up of new entities much more user-friendly. Previously a valid selection, and a red invalid border was displayed, which is at least confusing.
Closes DEICH-6288Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/602DEICH-0000 - Code style cleanup2022-06-23T12:27:20ZTom AdamDEICH-0000 - Code style cleanupCloses DEICH-0000Closes DEICH-0000Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/601DEICH-6286 - Filtering on empty tags2022-06-24T10:22:11ZTom AdamDEICH-6286 - Filtering on empty tagsHowever, we still need to allow for predefined tags with space at the start or end, which makes handleSubmitTag implementation a bit more complex.
Closes DEICH-6286However, we still need to allow for predefined tags with space at the start or end, which makes handleSubmitTag implementation a bit more complex.
Closes DEICH-6286Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/600DEICH-6285 - removed required2022-06-22T10:42:23ZTom AdamDEICH-6285 - removed requiredDette er såpass lita at jeg merger inn med en gang :smile:
Closes DEICH-6285Dette er såpass lita at jeg merger inn med en gang :smile:
Closes DEICH-6285Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/599DEICH-6284 Fixed EditDropDownMulti.svelte2022-06-22T08:10:55ZTom AdamDEICH-6284 Fixed EditDropDownMulti.svelteSe sakens beskrivelse for detaljer.Se sakens beskrivelse for detaljer.Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/598DEICH-6240 move declaration of abortController2022-06-22T08:23:06ZPetter Goksøyr ÅsenDEICH-6240 move declaration of abortControllerNeeds to be declared before search function, which is a user
of said abortController.
Closes DEICH-6240Needs to be declared before search function, which is a user
of said abortController.
Closes DEICH-6240http://gitlab.deichman.no/digibib/deichman/-/merge_requests/597DEICH-6271 - Added validation to library event sections2022-06-17T09:45:10ZTom AdamDEICH-6271 - Added validation to library event sectionsLibrary event sections is a dynamic form contained within a create or edit component.
Whether updating or creating a library event should be allowed or not, is dependent on the validation state of all the dynamic form elements added to ...Library event sections is a dynamic form contained within a create or edit component.
Whether updating or creating a library event should be allowed or not, is dependent on the validation state of all the dynamic form elements added to the arrangement sections.
On the other hand, the update/create parent component is not interested on the field level validation result of an arrangement section subcomponent (which consists of potentially many subfields with possible validation attached). To decide whether the save/create button should be enabled or not, it is enough to know, that all fields in a given section (Arrangementsseksjon/Medieseksjon/Blokkeseksjon) are valid.
Taking all this into consideration a new component was introduced, called Validatable (Validatable.svelte). This is a component with one slot, exposing its setValidProp method.
This method updates the propValidity object, which is indexed by all the property names included by a section component. In addition, there is a reactive property called allValid, which triggers an allValidChanged component event if all the input elements in the given section are valid (allValid === true), or some of them are invalid (allValid === false).
The event dispatched contains an object with a unique allValidKey key, which is a symbol (unique on component instance level after the component is attached to the slot of the wrapper Validatable). A single prop cannot be used in this case, since an allValidChanged event is valid for a whole section, potentially containing many properties.
This way the arrangement sections can contain whatever number of the same type of section, and still have a record of identifiable validity thanks to the unique symbol keys.
The allValidChanged component event is propagated to the create/update component using standard svelte component event propagation.
Note, that as the Validatable component is removed, an allValidChanged event is fires with a true value, since the component should not invalidate the create/update component any longer, it is recycled.
This mechanism is quite universal, so handling the Blokkeseksjon type was straightforward. That is basically a "section in the sections" setup. See the code for details.
In the future it is wise to take into use the Validatable component in case of non-section form sub-elements (like EditLibraryEventLocation, EditLibraryEventContent etc...), since in all those cases it is the same scenario: the create/update component is only interested in whether all fields requiring validation in the sub-form component are valid or not. This way quite a lot of code could be removed.
Closes DEICH-6271Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/596DEICH-6268 - Fixed mapping+tests as agreed.2022-06-14T08:17:22ZTom AdamDEICH-6268 - Fixed mapping+tests as agreed.Muligens blir det flere iterasjoner ettersom det er fortsatt none BS/DFB spesielle tilfeller. Må vurderes om det er verdt å bruke tid på disse (antall spesielle tilfeller er ukjent foreløpig).
Closes DEICH-6268Muligens blir det flere iterasjoner ettersom det er fortsatt none BS/DFB spesielle tilfeller. Må vurderes om det er verdt å bruke tid på disse (antall spesielle tilfeller er ukjent foreløpig).
Closes DEICH-6268Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/595Resolve DEICH-62692022-06-09T10:40:28ZBenjaminResolve DEICH-6269Closes DEICH-6269Closes DEICH-6269http://gitlab.deichman.no/digibib/deichman/-/merge_requests/594Draft: DEICH-5792 show production year for films in grid-mode2022-05-27T09:09:28ZTom AdamDraft: DEICH-5792 show production year for films in grid-modeDet er en del ting rundt saken som må avklares - derfor er dette i DRAFT.
Show in place of languages.
Closes DEICH-5792Det er en del ting rundt saken som må avklares - derfor er dette i DRAFT.
Show in place of languages.
Closes DEICH-5792http://gitlab.deichman.no/digibib/deichman/-/merge_requests/593DEICH-6248 - Fixed date parsing using date-fns.2022-05-25T06:17:56ZTom AdamDEICH-6248 - Fixed date parsing using date-fns.Closes DEICH-6248Closes DEICH-6248Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/592DEICH-6263 - Fixed link width.2022-05-27T05:39:47ZTom AdamDEICH-6263 - Fixed link width.Had to add yet another div :) so that we have control on thw width of an anchor element (by setting display to block in case of mobile view).
Closes DEICH-6263Had to add yet another div :) so that we have control on thw width of an anchor element (by setting display to block in case of mobile view).
Closes DEICH-6263Tom AdamTom Adam