deichman merge requestshttp://gitlab.deichman.no/digibib/deichman/-/merge_requests2022-06-19T23:37:08Zhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/591DEICH-6239 show most recent reccomendation in grid2022-06-19T23:37:08ZPetter Goksøyr ÅsenDEICH-6239 show most recent reccomendation in gridCloses DEICH-6239Closes DEICH-6239http://gitlab.deichman.no/digibib/deichman/-/merge_requests/590DEICH-5839 - Summary harvesting2022-05-27T05:30:38ZTom AdamDEICH-5839 - Summary harvesting DEICH-5839 Mimir changes
Extended mimir v2 api search possibilities to fetch missing summary in addition to missing cover candidates. The changes are implemented in such a way, that additional absent data harvesting might be easily... DEICH-5839 Mimir changes
Extended mimir v2 api search possibilities to fetch missing summary in addition to missing cover candidates. The changes are implemented in such a way, that additional absent data harvesting might be easily added to the code base.
The entry point of the search is - just like before - the no.deichman.mimir.discogs.controller.SearchController class (note, that the package should be renamed to no.deichman.mimir.harvesting.controller). The controller was altered to provide two end points, one for MARC21 search (/marc) and one for discogs (/discogs) for cleaner separation of concerns.
The code is built around the AbsentData enum class. This enum contains all currently supported, harvestable absent data (however, as of now discogs only supports cover image). A bit biased towards data coming form MARC21, each enum value is connected to a corresponding data extractor, which is responsible for extracting the data for the MARC21 end points (BIBBI, ALMA, DFB).
MARC21 end points are fetched in priority order (BIBBI, ALMA, DFB, from high to low). If an absent data is found, it is removed form the request towards the next source - so, if BIBBI finds a summary, the summary is not being tried to be fetched from ALMA or DFB (see test for details).
Multiple cover images are supported. Same is true for summary, however, does not give much of a value, since for the client it would be hard to decide which summary should be used (currently in such a case the client chooses the first hit).
Further changes:
-Removed option for extraQueryParts from QueryBuilderService - not needed any longer, since we potentially fetch other absent data in addition to cover image.
-Removed empty flag from Response.MarcResponse - just additional complexity, and can rather easily be filtered out on server side.
-Removed still unused data harvesting from discogs. The previous implementation is in the repo, but needs to be altered to fit into the new architecture on demand (the implementation should base itself on the AbsentData enum concept as well).
DEICH-5839 - Changes in cover-harvester
Modified the code to handle multiple missing data types, and all MARC21 search end points.
Increased test coverage (never enough).
Increased type safety and error handling, thus more stable run can be expected.
DEICH-5839 - Euler
Made required changes to enabled fetching and setting of absent data from/in virtuoso.
Refactored API. Renamed endpoints. Now the kind of absent data (OVER_IMAGE or SUMMARY) is also returned with the absent data candidate response.
More consistent use of publicationId - removed from request object, only part of data setter URL (set-data and harvest-attempt end-points).
Updated and renamed the absent data fetching sparql query.
Added required sparql templates to log harvesting attempts.
Changed harvest attempt naming - requires update script in prod - see the task comment added recently.
Added SetDataRequest base class which is to be used as base class for any further data harvesting efforts. The request classes themselves are responsible for generating the insert sparql statement. No more option for overwrite - anyway, it was not used, just additional complexity.
Json serialization/deserialization tests for SetDataRequest implementations.Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/589DEICH-6234 restrict KL borrowers to pickup branch 'hsko'2022-05-27T05:58:57ZPetter Goksøyr ÅsenDEICH-6234 restrict KL borrowers to pickup branch 'hsko'Closes DEICH-6234Closes DEICH-6234http://gitlab.deichman.no/digibib/deichman/-/merge_requests/588DEICH-6259 always show genre input field in wizard2022-05-27T05:49:17ZPetter Goksøyr ÅsenDEICH-6259 always show genre input field in wizardCloses DEICH-6259Closes DEICH-6259http://gitlab.deichman.no/digibib/deichman/-/merge_requests/587DEICH-6229 ensure borrower_sync table is populated for all borrowers2022-06-19T23:36:39ZPetter Goksøyr ÅsenDEICH-6229 ensure borrower_sync table is populated for all borrowersEvent if NL is not currently enabled, it could be in the future,
if patron register through another library for example.
Closes DEICH-6229Event if NL is not currently enabled, it could be in the future,
if patron register through another library for example.
Closes DEICH-6229http://gitlab.deichman.no/digibib/deichman/-/merge_requests/586DEICH-6115 improve error handling of user registration2022-05-11T08:26:15ZPetter Goksøyr ÅsenDEICH-6115 improve error handling of user registrationThe main problem is that return in try block does not return :-(
So while http response header was written with status code bad request,
the code after was still run. So user got respons bad request but meanwhile
somethings might have b...The main problem is that return in try block does not return :-(
So while http response header was written with status code bad request,
the code after was still run. So user got respons bad request but meanwhile
somethings might have been persisted which shouldn't have.
Closes DEICH-6115http://gitlab.deichman.no/digibib/deichman/-/merge_requests/585DEICH-6255 Added missing parameter replaceSuggestionNode2022-05-10T07:59:21ZTom AdamDEICH-6255 Added missing parameter replaceSuggestionNodeEnkel fiks.
Closes DEICH-6255Enkel fiks.
Closes DEICH-6255Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/584DEICH-6254: disregard fengselsbibliotek in check for allowed remote reserve2022-05-09T11:29:55ZBenjaminDEICH-6254: disregard fengselsbibliotek in check for allowed remote reserveCloses DEICH-6254Closes DEICH-6254http://gitlab.deichman.no/digibib/deichman/-/merge_requests/583Resolve DEICH-6246 "Dobbel hovedtittel verk"2022-05-11T08:08:37ZTom AdamResolve DEICH-6246 "Dobbel hovedtittel verk"Det blir en overgang ang. tittel med Berit og Guro, men i melloltiden kan dette merges inn som en midlertidlig fiks i god retning :)
Closes DEICH-6246Det blir en overgang ang. tittel med Berit og Guro, men i melloltiden kan dette merges inn som en midlertidlig fiks i god retning :)
Closes DEICH-6246Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/582Resolve DEICH-62432022-05-09T23:34:56ZPetter Goksøyr ÅsenResolve DEICH-6243Closes DEICH-6243Closes DEICH-6243http://gitlab.deichman.no/digibib/deichman/-/merge_requests/581DEICH-6251 replace workseries suggestion node in wizard2022-05-09T23:23:43ZPetter Goksøyr ÅsenDEICH-6251 replace workseries suggestion node in wizardCloses DEICH-6251Closes DEICH-6251http://gitlab.deichman.no/digibib/deichman/-/merge_requests/580DEICH-6244 remove blank node ids from agent nodes2022-05-09T23:25:28ZPetter Goksøyr ÅsenDEICH-6244 remove blank node ids from agent nodesCloses DEICH-6244Closes DEICH-6244http://gitlab.deichman.no/digibib/deichman/-/merge_requests/579DEICH-5792 add more info to films in grid mode2022-05-11T23:15:27ZPetter Goksøyr ÅsenDEICH-5792 add more info to films in grid mode* Show production year in place of languages.
* Show director in place of main entry.
* Also fixes a bug so that production year is shown in list-mode,
with the correct label.
Closes DEICH-5792* Show production year in place of languages.
* Show director in place of main entry.
* Also fixes a bug so that production year is shown in list-mode,
with the correct label.
Closes DEICH-5792http://gitlab.deichman.no/digibib/deichman/-/merge_requests/578DEICH-6245: add location for new subcollection faeroeysk2022-05-06T08:42:12ZBenjaminDEICH-6245: add location for new subcollection faeroeyskCloses DEICH-6245Closes DEICH-6245http://gitlab.deichman.no/digibib/deichman/-/merge_requests/577DEICH-0000 Added missing BIBBI config.2022-05-05T10:00:49ZTom AdamDEICH-0000 Added missing BIBBI config.Closes DEICH-0000Closes DEICH-0000Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/576DEICH-6241 - Fixed language dependency.2022-05-05T09:38:16ZTom AdamDEICH-6241 - Fixed language dependency.Closes DEICH-6241Closes DEICH-6241Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/575DEICH-6230 - Cover image - book2022-05-12T05:15:48ZTom AdamDEICH-6230 - Cover image - bookDEICH-6230 - Made mapFormat more lenient - mapping the format will only be important for discogs in the future.
DEICH-6230 - Refactoring - simplified mediaType
It is only EulerAdapter in cover harvester who knows about the diff...DEICH-6230 - Made mapFormat more lenient - mapping the format will only be important for discogs in the future.
DEICH-6230 - Refactoring - simplified mediaType
It is only EulerAdapter in cover harvester who knows about the different MediaType representations (MediaTypes.MUSIC_RECORDING vs. MusicRecording in Euler data).
This mapping was entirely moved to EulerAdapter (using MediaTypeConverter defined in constants.js).
Provider is not needed, since EulerAdapter can be called directly.
Data cleaning (removal og id prefix and media type mapping) all happens in EulerAdapter - from the adapter level above it is only clean and properly baked domain objects we deal with.
DEICH-6230 - ESLint/Prettier fix
DEICH-6230 - Code cleanup - Processor
DEICH-6230 - Code cleanup Removed check for a case that never occurs - fetchImageFromUrl throws error if things go banana, otherwise _always_ returns an object.
DEICH-6230 - Typo and test timeout fix.
DEICH-6230 - Added support for book cover images from Mimir.
DEICH-6230 - Mimir BIBBI search for book cover imagesAdded support for bibbi based cover image search for books.
Multiple return type (see no.deichman.mimir.discogs.dto.Result / no.deichman.mimir.discogs.dto.SearchResponse) for /api/v2/search - the same approach that was introduced for the new FP search API.
Some API simplifications (the cover harvester invokes only one source, so no point in having sources as a List in SearchPayload.java).
Smaller code improvements/cleanup.
DEICH-6230 - Improved const definition Moved declaration and usage place together. Also freezing objects - they cannot be modified by mistake.
DEICH-6230 - Renamed BS to BIBBI, removed BokBasen (BB) -Some additional small refactorings in MimirAdapter (moved sub-methods to class level as private methods).
DEICH-6230 - added common findCandidates Fetches candidates for specific media types.
DEICH-6230 - Some code improvements
Closes DEICH-6230Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/574DEICH-6204 - added fetch error handlers2022-04-21T08:28:42ZTom AdamDEICH-6204 - added fetch error handlersWe were missing error handlers if the fetch call itself fails - fixed.
Closes DEICH-6204We were missing error handlers if the fetch call itself fails - fixed.
Closes DEICH-6204Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/573DEICH-6226 bring back GA init code lost in refactoring2022-04-19T09:07:59ZPetter Goksøyr ÅsenDEICH-6226 bring back GA init code lost in refactoringDette forsvant i c1936aeb0b7445ebc52a71f8af07ca464bcc2d0c
Closes DEICH-6226Dette forsvant i c1936aeb0b7445ebc52a71f8af07ca464bcc2d0c
Closes DEICH-6226http://gitlab.deichman.no/digibib/deichman/-/merge_requests/572DEICH-6218 fix issues found when testing DFB records2022-04-20T08:07:36ZPetter Goksøyr ÅsenDEICH-6218 fix issues found when testing DFB recordsSe individual commits for details
Closes DEICH-6218Se individual commits for details
Closes DEICH-6218