deichman merge requestshttp://gitlab.deichman.no/digibib/deichman/-/merge_requests2022-04-04T11:23:01Zhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/568DEICH-6218 - Various fixes and enhancements2022-04-04T11:23:01ZPetter Goksøyr ÅsenDEICH-6218 - Various fixes and enhancements-some additional test and code improvements
Closes DEICH-6218-some additional test and code improvements
Closes DEICH-6218http://gitlab.deichman.no/digibib/deichman/-/merge_requests/567DEICH-6218 - Fixed forlagsserier mapping2022-04-01T08:40:48ZTom AdamDEICH-6218 - Fixed forlagsserier mapping-added mapping for field *505.
-some fixes to subject mappings
-fixed field+map entry sorting in DeichMapper
-not checking leader char 7 for `s` any longer
-*490 is used primarily, *830 is fallback
-disabled SearchResponseTest
-map 'bild...-added mapping for field *505.
-some fixes to subject mappings
-fixed field+map entry sorting in DeichMapper
-not checking leader char 7 for `s` any longer
-*490 is used primarily, *830 is fallback
-disabled SearchResponseTest
-map 'bildbøker' from NTSF
-map marc realtor 'clr' to role scriptWriterTom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/566DEICH-6219 deichman.no: remove parsing of query params in logout redirect2022-04-07T07:10:24ZBenjaminDEICH-6219 deichman.no: remove parsing of query params in logout redirectCloses DEICH-6219Closes DEICH-6219http://gitlab.deichman.no/digibib/deichman/-/merge_requests/565DEICH-6210 shield more of the catalogue from ill requests2022-04-05T10:55:58ZPetter Goksøyr ÅsenDEICH-6210 shield more of the catalogue from ill requestsThe following conditions are added/updated
* Disallow requests if biblio is more recent than 3 years (was 3 months)
* Disallow mediatype ComicBook (Tegneserie)
* Disallow mediatype Book if languge is Bokmål or Nynorsk
Closes DEICH-6210The following conditions are added/updated
* Disallow requests if biblio is more recent than 3 years (was 3 months)
* Disallow mediatype ComicBook (Tegneserie)
* Disallow mediatype Book if languge is Bokmål or Nynorsk
Closes DEICH-6210http://gitlab.deichman.no/digibib/deichman/-/merge_requests/564DEICH-6215 - DFB using MARC212022-03-30T11:07:40ZTom AdamDEICH-6215 - DFB using MARC21In its current form the code is usable, however the mapping part is kind of a monolith. I suggest code refactoring to the approach we talked about: small mapper utility classes getting the whole record (not just a field), and fetch the d...In its current form the code is usable, however the mapping part is kind of a monolith. I suggest code refactoring to the approach we talked about: small mapper utility classes getting the whole record (not just a field), and fetch the dat needed to create subjects, contributors etc...
Tests should be also made uniform when it comes to creating the test models. We should use the text block + parse approach all places.
Closes DEICH-6215Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/563DEICH-0000 - Code cleanup to have a version for prod2022-03-25T14:19:29ZTom AdamDEICH-0000 - Code cleanup to have a version for prod-removed enabled flag on sources
-disabled some tests, that will be enabled as MARC21 verification is done
Closes DEICH-0000-removed enabled flag on sources
-disabled some tests, that will be enabled as MARC21 verification is done
Closes DEICH-0000Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/562DEICH-6212 adjust which items is regarded as "Feilplassert"2022-03-28T11:26:38ZPetter Goksøyr ÅsenDEICH-6212 adjust which items is regarded as "Feilplassert"While processsing scans coming from hyllerydder:
"Feilplassert" is set under the following conditions:
* item has location co on branch A, but scanned on branch B
* item has location lives on branch A (and no location ca), but scanned o...While processsing scans coming from hyllerydder:
"Feilplassert" is set under the following conditions:
* item has location co on branch A, but scanned on branch B
* item has location lives on branch A (and no location ca), but scanned on branch B
* item has location goes set, but not arrived and assigned a pickup-shelf-number
Closes DEICH-6212http://gitlab.deichman.no/digibib/deichman/-/merge_requests/561DEICH-6123 koha: update Item::GetBySeenLocation conditions2022-03-28T11:27:18ZPetter Goksøyr ÅsenDEICH-6123 koha: update Item::GetBySeenLocation conditionsInclude items with loststatus 7/9: På hentehylle - avbestilt/utgått
Closes DEICH-6213Include items with loststatus 7/9: På hentehylle - avbestilt/utgått
Closes DEICH-6213http://gitlab.deichman.no/digibib/deichman/-/merge_requests/560DEICH-6208 Fixes perspective - was set on wrong parent.2022-03-24T12:20:20ZTom AdamDEICH-6208 Fixes perspective - was set on wrong parent.Da er denne fyren tilbake på en tur igjen :)
Jeg har testet formidlingskkjemnene på Safari, hvis CSS perspective prop egentlig fungerte, og visningene er ca. 6*10^23 (Avogadro rull) cooler enn uten denne fiksen.
Thxs Safari & Da er denne fyren tilbake på en tur igjen :)
Jeg har testet formidlingskkjemnene på Safari, hvis CSS perspective prop egentlig fungerte, og visningene er ca. 6*10^23 (Avogadro rull) cooler enn uten denne fiksen.
Thxs Safari & Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/559DEICH-6211 Info screen empty slides fix2022-03-24T09:39:05ZTom AdamDEICH-6211 Info screen empty slides fixCloses DEICH-6211Closes DEICH-6211Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/558DEICH-6208 Small CSS fixes2022-03-24T09:39:49ZTom AdamDEICH-6208 Small CSS fixes-Moved CSS var definitions to global-styles.css
-Fixed undefined/mistyped color var definitions
-Used special post-css build script to get a report of undefined or not globally defined css vars
Closes DEICH-6208-Moved CSS var definitions to global-styles.css
-Fixed undefined/mistyped color var definitions
-Used special post-css build script to get a report of undefined or not globally defined css vars
Closes DEICH-6208Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/557DEICH-6207 Show logout for employees2022-03-23T09:54:47ZTom AdamDEICH-6207 Show logout for employeesCloses DEICH-6207Closes DEICH-6207Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/556DEICH-6162 Using new version of deichman-ui2022-03-23T09:53:14ZTom AdamDEICH-6162 Using new version of deichman-uiThis fix has a related fix in deichman-ui, which has been code-reviewed, ande deployed to nmp-registry.
Closes DEICH-6162This fix has a related fix in deichman-ui, which has been code-reviewed, ande deployed to nmp-registry.
Closes DEICH-6162Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/555DEICH-6199 - Fixed issue with history navigation2022-03-18T08:37:36ZTom AdamDEICH-6199 - Fixed issue with history navigationAn issue was found related to moving back in history: the [Utforsk alle bøker og medier] button did n ot show up.
In addition, the button for normal search has disappeared right away before the autocomplete list was displayed.
To overco...An issue was found related to moving back in history: the [Utforsk alle bøker og medier] button did n ot show up.
In addition, the button for normal search has disappeared right away before the autocomplete list was displayed.
To overcome these issues the Header component is listening to dropdownShowing callbacks, which originates from the CommandSearch or Autocomplete components.
To guarantee correct functioning of CommandSearch, the component must always be part of the REACT dom, so that it can notify Search->Header as its dropdown is hidden.
Closes DEICH-6199Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/554Resolve DEICH-6204 "Felles responsehandler"2022-03-28T08:32:12ZTom AdamResolve DEICH-6204 "Felles responsehandler"Closes DEICH-6204Closes DEICH-6204Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/553Resolve DEICH-0000 "Små forbedinger"2022-04-08T07:54:08ZTom AdamResolve DEICH-0000 "Små forbedinger"Kanskje vi kan legge til noen andre små opprydninger/forbedringer?
Closes DEICH-0000Kanskje vi kan legge til noen andre små opprydninger/forbedringer?
Closes DEICH-0000Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/552DEICH-6202 - Fixed focus trap config2022-03-24T19:11:33ZTom AdamDEICH-6202 - Fixed focus trap configTo avoid focusing back on original element in list filter when collapse state changes due to a click outside the component.
Some code cleanup around filter naming.
Closes DEICH-6202To avoid focusing back on original element in list filter when collapse state changes due to a click outside the component.
Some code cleanup around filter naming.
Closes DEICH-6202Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/551DEICH-6203 - Fixed IspirationCard if no recommendations are provided by Sibyl2022-03-24T09:44:54ZTom AdamDEICH-6203 - Fixed IspirationCard if no recommendations are provided by SibylEmpty JSON arrays are mapped to null in Go, which causes some trouble in this case. It was easier to have it fixed on the client side, than to write a custom null-array serializer in Go.
Closes DEICH-6203Empty JSON arrays are mapped to null in Go, which causes some trouble in this case. It was easier to have it fixed on the client side, than to write a custom null-array serializer in Go.
Closes DEICH-6203Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/550DEICH-6200 - Loader animation hangs2022-03-24T19:17:45ZTom AdamDEICH-6200 - Loader animation hangs-Fixed condition making loader animations hang on empty data from server.
-Removed unused re-assign+non-existing second parameter
-Added default value to req (SonarLint fix)
-Removed redundant regexp escaping
-Removed redundant variable ...-Fixed condition making loader animations hang on empty data from server.
-Removed unused re-assign+non-existing second parameter
-Added default value to req (SonarLint fix)
-Removed redundant regexp escaping
-Removed redundant variable initializers
-Removed redundant local variable (locationQuery)
Closes DEICH-6200Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/549DEICH-6199 - Fixed search all button hide when Search input is not empty2022-03-17T09:06:50ZTom AdamDEICH-6199 - Fixed search all button hide when Search input is not emptyCloses DEICH-6199Closes DEICH-6199Tom AdamTom Adam