deichman merge requestshttp://gitlab.deichman.no/digibib/deichman/-/merge_requests2022-10-18T10:54:04Zhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/681DEICH-6403 - Invalid section improvements2022-10-18T10:54:04ZTom AdamDEICH-6403 - Invalid section improvementsIf a section/block section is not valid, it gets opened by default, and no sections/block sections with invalid data can be closed. This required changes in ValidationContext (to fire event about sub-context validity) and in DragAndDropI...If a section/block section is not valid, it gets opened by default, and no sections/block sections with invalid data can be closed. This required changes in ValidationContext (to fire event about sub-context validity) and in DragAndDropItem, to propagate content validity state. Also sections/block sections had to wire up and propaget their validity state to their parent DragAndDropItem instance.
Also dumping allValid flag as part og $$_dumpValidationContext().
Fixed issue with sometimes unset validationContext data in $$_dumpValidationContext().
Some layout goodies (using Grid/GridItem in EditPageSectionGeneric)
Closes DEICH-6403Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/667DEICH-6384 - Fixed requested changes in how filtering/sorting works together2022-10-06T10:47:32ZTom AdamDEICH-6384 - Fixed requested changes in how filtering/sorting works togetherHad to change how DateRangeFilterDropdown works, now there is direct binding to the selected filter instead of component event handling.
Added option to have default filters (isDefault flag), which makes the given filter non-removable.
...Had to change how DateRangeFilterDropdown works, now there is direct binding to the selected filter instead of component event handling.
Added option to have default filters (isDefault flag), which makes the given filter non-removable.
"Fjern alle" was renamed to "Nullstill Filtrering" - makes more sense, since the default date filter stays in command even after removing all others.
Exposed possible date filter options in module context inside DateRangeFilterDropdown.
Closes DEICH-6384Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/635DEICH-6334 - Fuge autocomplete goodies for å støtte hyllesignatur format (plu...2022-08-24T07:52:18ZTom AdamDEICH-6334 - Fuge autocomplete goodies for å støtte hyllesignatur format (pluss noen bug-fixes)DEICH-6334 - Added DropDownState tests to cover rollOverHighlight and filterHighlightMode (related to the new allowFreeText and autoHighlightSingle Autocomplete properties)
Closes DEICH-6334DEICH-6334 - Added DropDownState tests to cover rollOverHighlight and filterHighlightMode (related to the new allowFreeText and autoHighlightSingle Autocomplete properties)
Closes DEICH-6334Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/627DEICH-6325 - Upgrade to WebPack 5 + cache busting 🚀2022-08-12T12:26:10ZTom AdamDEICH-6325 - Upgrade to WebPack 5 + cache busting 🚀- Upgraded to webpack 5 🎉
- Fixed module reload for WebPack 5, however could only make it work with sockjs.
- Added automatic cleanup for `public` folder - otherwise it gets full with different bundle cache busted bundle
versions...- Upgraded to webpack 5 🎉
- Fixed module reload for WebPack 5, however could only make it work with sockjs.
- Added automatic cleanup for `public` folder - otherwise it gets full with different bundle cache busted bundle
versions.
- Added cache busting 🎉
- The webpack config was modified to add `contenthash` to the generated bundle names (both js, and css).
HtmlWebpackPlugin is used to generate public/index.html based on template stored in `./assets/index.html`.
- `global.css` was moved inside the `src/css` folder, and now included in `App.svelte`. All declarations were converted
to have global scope. This was required to avoid caching `global.css`, thus invalidating cache busting partially.
Closes DEICH-6325Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/593DEICH-6248 - Fixed date parsing using date-fns.2022-05-25T06:17:56ZTom AdamDEICH-6248 - Fixed date parsing using date-fns.Closes DEICH-6248Closes DEICH-6248Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/583Resolve DEICH-6246 "Dobbel hovedtittel verk"2022-05-11T08:08:37ZTom AdamResolve DEICH-6246 "Dobbel hovedtittel verk"Det blir en overgang ang. tittel med Berit og Guro, men i melloltiden kan dette merges inn som en midlertidlig fiks i god retning :)
Closes DEICH-6246Det blir en overgang ang. tittel med Berit og Guro, men i melloltiden kan dette merges inn som en midlertidlig fiks i god retning :)
Closes DEICH-6246Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/570DEICH-6218 - Generic handling for subfield followed by another subfield mappi...2022-04-11T11:03:25ZTom AdamDEICH-6218 - Generic handling for subfield followed by another subfield mapping scenario+anthology title mapping (*505$t$r)Closes DEICH-6218Closes DEICH-6218Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/558DEICH-6208 Small CSS fixes2022-03-24T09:39:49ZTom AdamDEICH-6208 Small CSS fixes-Moved CSS var definitions to global-styles.css
-Fixed undefined/mistyped color var definitions
-Used special post-css build script to get a report of undefined or not globally defined css vars
Closes DEICH-6208-Moved CSS var definitions to global-styles.css
-Fixed undefined/mistyped color var definitions
-Used special post-css build script to get a report of undefined or not globally defined css vars
Closes DEICH-6208Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/555DEICH-6199 - Fixed issue with history navigation2022-03-18T08:37:36ZTom AdamDEICH-6199 - Fixed issue with history navigationAn issue was found related to moving back in history: the [Utforsk alle bøker og medier] button did n ot show up.
In addition, the button for normal search has disappeared right away before the autocomplete list was displayed.
To overco...An issue was found related to moving back in history: the [Utforsk alle bøker og medier] button did n ot show up.
In addition, the button for normal search has disappeared right away before the autocomplete list was displayed.
To overcome these issues the Header component is listening to dropdownShowing callbacks, which originates from the CommandSearch or Autocomplete components.
To guarantee correct functioning of CommandSearch, the component must always be part of the REACT dom, so that it can notify Search->Header as its dropdown is hidden.
Closes DEICH-6199Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/528DEICH-6102 - ind2HasOneOf simplifications2022-02-16T11:31:50ZTom AdamDEICH-6102 - ind2HasOneOf simplificationsThe function was returning an Optional and its value was never used. Rewritten code to replace return type with boolean. Also eliminated some hard to read ifPresentOrElse constructs.The function was returning an Optional and its value was never used. Rewritten code to replace return type with boolean. Also eliminated some hard to read ifPresentOrElse constructs.Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/516DEICH-6154 update ES to avoid log4j RCE2022-02-03T09:45:42ZTorsteinDEICH-6154 update ES to avoid log4j RCEThere are breaking changes, but none seem to hit Deichman's usage.
The changes in the config is to avoid warnings.
The discovery-type is a security measure.
The code was tested locally and a full reindexing was done with good results.
...There are breaking changes, but none seem to hit Deichman's usage.
The changes in the config is to avoid warnings.
The discovery-type is a security measure.
The code was tested locally and a full reindexing was done with good results.
- Search and autocomplete was done in prod and locally on ~same data and gave the ~same results (prod index is likely slightly out of sync)
- There are slight differences in ordering on automcomplete (can be because of difference in underlying data which affects ranking)
As a part of the release, me and Petter have discussed doing a "clean slate" reindexing to try to get the production index in sync.
This means that we can safely deploy this code, but we should do reindexing the same evening.
NOTE: this procedure should be done in the test environment first!
- Notify about potential issues with search to operations and on Workplace
- Stop Sibyl and Elasticsearch
- `TRUNCATE sibyl.index_docs` and `TRUNCATE sibyl.koha_cache` in Sibyl's DB
- Optional: consider deleting the elasticsearch volume (`docker volume rm deichman_elasticsearch_data`)
- Bring up ES check logs, if ok, bring up Sibyl
- Wait for Koha-cache to be updated in Sibyl (takes a few minutes)
- Start full reindexing
- Wait... :)
Closes DEICH-6154http://gitlab.deichman.no/digibib/deichman/-/merge_requests/72DEICH-5236: Allow e-mail to be updated for IL and BIB users without...2020-12-15T09:09:07ZMagnus WestergaardDEICH-5236: Allow e-mail to be updated for IL and BIB users without...DEICH-5236: Allow e-mail to be updated for IL and BIB users without verification (synced from BaseBibliotek). Allow BIB users to have their passwords updated.
Closes DEICH-5236DEICH-5236: Allow e-mail to be updated for IL and BIB users without verification (synced from BaseBibliotek). Allow BIB users to have their passwords updated.
Closes DEICH-5236http://gitlab.deichman.no/digibib/deichman/-/merge_requests/51Resolve DEICH-5311 "Es scoring norm"2020-12-01T12:56:54ZMagnus WestergaardResolve DEICH-5311 "Es scoring norm"Closes DEICH-5311Closes DEICH-5311Petter Goksøyr ÅsenPetter Goksøyr Åsenhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/30DEICH-5334 Deichman.no: removed old countdown code2020-11-17T20:06:51ZMattias LundmarkDEICH-5334 Deichman.no: removed old countdown codeCloses DEICH-5334Closes DEICH-5334http://gitlab.deichman.no/digibib/deichman/-/merge_requests/12DEICH-3668 initial commit metrics.2020-04-17T19:22:06ZArnljot ArntsenDEICH-3668 initial commit metrics.Mattias LundmarkMattias Lundmarkhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/7Reservationmanager2019-05-13T03:32:48ZBårdReservationmanagerGreit å ta en rask scroll igjennom.Greit å ta en rask scroll igjennom.Petter Goksøyr ÅsenPetter Goksøyr Åsenhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/5Ie112019-04-25T06:14:10ZBårdIe11- Legacy browser support
- Removed debugger package
- Removed "*" in search for default search page (to make search terminals display input field)- Legacy browser support
- Removed debugger package
- Removed "*" in search for default search page (to make search terminals display input field)http://gitlab.deichman.no/digibib/deichman/-/merge_requests/691DEICH-6436 tjenestekat: add some simplified tour and group visit concepts for...2023-01-02T08:33:59ZBenjaminDEICH-6436 tjenestekat: add some simplified tour and group visit concepts for reportingsparql i jira: https://jira.oslo.kommune.no/browse/DEICH-6436sparql i jira: https://jira.oslo.kommune.no/browse/DEICH-6436http://gitlab.deichman.no/digibib/deichman/-/merge_requests/690DEICH-6353 - 6XY$x$y$z mapping fix + test code improvements2022-12-08T09:35:42ZTom AdamDEICH-6353 - 6XY$x$y$z mapping fix + test code improvementsDEICH-6353 - 6XY$x$y$z mapping fix + test code improvements
Mapping changes:
-600
Missing mapping for $y was added
-610
Had no $x/$y/$z mapping at all, was fixed.
-611
Had no $x/$y/$z mapping, fixed.
-630...DEICH-6353 - 6XY$x$y$z mapping fix + test code improvements
Mapping changes:
-600
Missing mapping for $y was added
-610
Had no $x/$y/$z mapping at all, was fixed.
-611
Had no $x/$y/$z mapping, fixed.
-630
Had no $x/$y/$z mapping, fixed.
-651
There was an inhereted codeing error, $x is used for reieshåndbok mapping, but if the value is not “reisehåndbøker” $x was mapped to PLACE. Fixed, $x is mapped til SUBJECT now. Added support for multiple occurrences of $x (as defined in LOC MARC21 specification).
$a and $z both maps to PLACE (was already done so before) - not changed.
$y mapping was missing, fixed.
-653
Has no $x/$y/$z.
-655
Here there is an exception, $z is mapped to Work/NATIONALITY (and this is correct this way). Otherwise added missing $x/$y mapping.
Added required tests to cover all these new cases.
Removed disabled test case test6XXxSubjects - those scenarios were covered now.
Test utility improvements:
-Renamed assertDeichModelContainsTriple to assertDeichModelContainsExactlyOneTriple, name was misleading.
Added public static void assertDeichModelContainsSubjectPrefLabels(Model deichModel, Ontology forOntology, String ...prefLabels) replacing assertDeichModelContainsSubjectsWithPrefLabels, assertDeichModelContainsSubjectWithPrefLabel, assertDeichModelContainsSubjectPlaceWithPrefLabel
DEICH-6353 - Removed unused mapping and invalid test cases.
DEICH-6353 Mapping changes 082-083 - classification
Closes DEICH-6353Tom AdamTom Adamhttp://gitlab.deichman.no/digibib/deichman/-/merge_requests/689DEICH-6429 - Avvikende/Meråpent opprydning2022-11-25T09:41:54ZTom AdamDEICH-6429 - Avvikende/Meråpent opprydningDEICH-6429 - Fixed arrogant date monster
It was just creeping through the deviating hours like hell. Until today. Now this bastard was caught, and eliminated.
Reason for the bug was that EditInterval did not allow for s...DEICH-6429 - Fixed arrogant date monster
It was just creeping through the deviating hours like hell. Until today. Now this bastard was caught, and eliminated.
Reason for the bug was that EditInterval did not allow for setting the periodStart/periodEnd besides the initial setup. Now there was made a change to set the interval ends in flatpickr as these props are set, and fire the interval change in the flatpickr options hook. It was actually he opposite before, thus causing problems.
DEICH-6429 - Added cleanup logic for meråpent
Now the deviating hours are set correctly.
- normal opening open flag is set to true;
- openFrom/To is set to mannedFrom/To
- manned, mannedFrom/To is deleted.
Closes DEICH-6429.Tom AdamTom Adam