GitLab

This way there is no id collision for input-datalist pairs.

Also removed export from `value` property. Should not be exposed.

Closes DEICH-6296

Closes DEICH-6297

Closes DEICH-6291

However, we still need to allow for predefined tags with space at the start or end, which makes handleSubmitTag implementation a bit more complex.

Closes DEICH-6286

DEICH-6281 - Fixed validation so that it is instantly fired as the valid flag is updated using svelte reactive declarations.

Note, that EditNumber is used only one place with required set to false, so testing that component in validation sense is not possible by testers. Did a local testing, works ok.

EditNumber`s functionality was improved. The previous version allowed typing of non-numeric characters in the input fields, and there was no error reported at all. In this case the value was set to undefined, but still looked strange, that the create/save button was enabled. This new version fixes this issue. The implementation was somewhat cumbersome since I had to listen to onkeyup event, and check the input validity through input.validity.valid.

Closes DEICH-6281

Also made the control somewhat smarter: if no item is selected, and enableEmptySelection is false, the --- Velg --- placeholder is displayed. It makes setting up of new entities much more user-friendly. Previously a valid selection, and a red invalid border was displayed, which is at least confusing.

Closes DEICH-6288

Closes DEICH-0000

Dette er såpass lita at jeg merger inn med en gang 😄 

Closes DEICH-6285

DEICH-6284 Fixed select to placeholder based on index - was not working for ffox on OSx and ffox and chrome on windows.

Petter Goksøyr Åsen authored Jun 22, 2022 and Tom Adam committed Jun 22, 2022

Needs to be declared before search function, which is a user
of said abortController.

Closes DEICH-6240

Se sakens beskrivelse for detaljer.

Closes DEICH-6239

Event if NL is not currently enabled, it could be in the future,
if patron register through another library for example.

Closes DEICH-6229

Tom Adam authored Jun 17, 2022 and Benjamin committed Jun 17, 2022

Library event sections is a dynamic form contained within a create or edit component.

Whether updating or creating a library event should be allowed or not, is dependent on the validation state of all the dynamic form elements added to the arrangement sections.

On the other hand, the update/create parent component is not interested on the field level validation result of an arrangement section subcomponent (which consists of potentially many subfields with possible validation attached). To decide whether the save/create button should be enabled or not, it is enough to know, that all fields in a given section (Arrangementsseksjon/Medieseksjon/Blokkeseksjon) are valid.

Taking all this into consideration a new component was introduced, called Validatable (Validatable.svelte). This is a component with one slot, exposing its setValidProp method.

  This method updates the propValidity object, which is indexed by all the property names included by a section component. In addition, there is a reactive property called allValid, which triggers an allValidChanged component event if all the input elements in the given section are valid (allValid === true), or some of them are invalid (allValid === false).

  The event dispatched contains an object with a unique allValidKey key, which is a symbol (unique on component instance level after the component is attached to the slot of the wrapper Validatable). A single prop cannot be used in this case, since an allValidChanged event is valid for a whole section, potentially containing many properties.

  This way the arrangement sections can contain whatever number of the same type of section, and still have a record of identifiable validity thanks to the unique symbol keys.

  The allValidChanged component event is propagated to the create/update component using standard svelte component event propagation.

  Note, that as the Validatable component is removed, an allValidChanged event is fires with a true value, since the component should not invalidate the create/update component any longer, it is recycled.

  This mechanism is quite universal, so handling the Blokkeseksjon type was straightforward. That is basically a "section in the sections" setup. See the code for details.

  In the future it is wise to take into use the Validatable component in case of non-section form sub-elements (like EditLibraryEventLocation, EditLibraryEventContent etc...), since in all those cases it is the same scenario: the create/update component is only interested in whether all fields requiring validation in the sub-form component are valid or not. This way quite a lot of code could be removed.

Closes DEICH-6271

Muligens blir det flere iterasjoner ettersom det er fortsatt none BS/DFB spesielle tilfeller. Må vurderes om det er verdt å bruke tid på disse (antall spesielle tilfeller er ukjent foreløpig).

Closes DEICH-6268

Closes DEICH-6269

This reverts commit ab124968.

This reverts commit 2061cd4f.

This reverts commit 8dd06bc9.

Closes DEICH-6234

Closes DEICH-6259

Had to add yet another div :) so that we have control on thw width of an anchor element (by setting display to block in case of mobile view).

Closes DEICH-6263