Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D deichman
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 3
    • Merge requests 3
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • digibib
  • deichman
  • Merge requests
  • !122

DEICH-5562 replace modal for showing feeedback form with a regular link

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Torstein requested to merge 2021-02-02.hotfix.b2 into master Feb 04, 2021
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

The related issue details a bug where the modal doesn't always expand to show the whole form.

There's also complexities and security issues related to CSP because the content is served in an IFRAME from cognitoforms.com

The solution provided is simpler, cleaner and more secure. The only possible tradeoff is that it opens a new tab when then user clicks the link.

Closes #2021

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 2021-02-02.hotfix.b2