Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D deichman
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 3
    • Merge requests 3
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • digibib
  • deichman
  • Merge requests
  • !604

DEICH-6281 - Fixed validation so that it is instantly fired as the valid flag...

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tom Adam requested to merge DEICH-6281-onblur-validering-bug into master Jun 22, 2022
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 5

DEICH-6281 - Fixed validation so that it is instantly fired as the valid flag is updated using svelte reactive declarations.

Note, that EditNumber is used only one place with required set to false, so testing that component in validation sense is not possible by testers. Did a local testing, works ok.

EditNumber`s functionality was improved. The previous version allowed typing of non-numeric characters in the input fields, and there was no error reported at all. In this case the value was set to undefined, but still looked strange, that the create/save button was enabled. This new version fixes this issue. The implementation was somewhat cumbersome since I had to listen to onkeyup event, and check the input validity through input.validity.valid.

Closes DEICH-6281

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: DEICH-6281-onblur-validering-bug