Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D deichman
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 3
    • Merge requests 3
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • digibib
  • deichman
  • Merge requests
  • !658

DEICH-6373 - TK - Some search improvements, bug-fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tom Adam requested to merge DEICH-6373 into master Sep 30, 2022
  • Overview 4
  • Commits 5
  • Pipelines 0
  • Changes 24

DEICH-6373 - TK - Some search improvements, as detailed below

Fixed date range select

 Uses luxon date.
 Added filtering of selected date filter (does not show up in available list).

Additional filtering fix

 Previously the available branches and categories were fetched from the result aggregate. This resulted in a narrowed down category and branch selection option after filtering (i.e.: 1 item). This was changed, now all branches and all categories are visible always. Also, filters were updated not to contain already selected items.

Refurbished sorting

 Made ordered sorting of multiple fields possible (index displayed in sorting header). Current sortable fields are date, title and category.

More component reuse

 Both, FilterDropdown and DateRangeFilterDropdown uses EditDropDown.
 Added reusable wrapper, SortOderButton.

Misc

 Fixed `;` in webpack.config.js.

DEICH-6373 - Added support to object typed ids (so that the component can be reused for date filtering in LibraryEventSearch)

DEICH-6373 - Sibyl - fixed consistent sort order when multiple sort fields are defined.

Previously a map was used, to store SortParameters, however, maps do not guarantee the retrieval order. This has cosed inconsistent behaviour as TK introduced multiple sort field option.

DEICH-6373 - Validation framework addition - skipValidation

If set to true, the given input component is not taking part in the validation framework. All validation setup elated error messages are suspended.

In addition improved EditDropDown re-usability so as that it can be used in LibraryEventSearch.
Edited Sep 30, 2022 by Tom Adam
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: DEICH-6373